Re: [PATCH v2 08/13] qemu: don't shutdown event thread in monitor EOF callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 23, 2020 at 01:14:08PM +0300, Nikolay Shirokovskiy wrote:
> This hunk was introduced in [1] in order to avoid loosing
> events from monitor on stopping qemu process. But as explained
> in [2] on destroy we won't get neither EOF nor any other
> events as monitor is just closed. In case of crash/shutdown
> we won't get any more events as well and qemuDomainObjStopWorker
> will be called by qemuProcessStop eventually. Thus let's
> remove qemuDomainObjStopWorker from qemuProcessHandleMonitorEOF
> as it is not useful anymore.
> 
> [1] e6afacb0f: qemu: start/stop an event loop thread for domains
> [2] d2954c072: qemu: ensure domain event thread is always stopped
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
> ---
>  src/qemu/qemu_process.c | 3 ---
>  1 file changed, 3 deletions(-)


Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux