On Thu, 2020-09-03 at 11:24 -0400, Laine Stump wrote: > On 9/3/20 4:24 AM, Michal Privoznik wrote: > > +/* In order to have proper rl_message declaration with older > > + * versions of readline, we have to declare this. See 9ea3424a178 > > + * for more info. */ > > +# define HAVE_STDARG_H > > # include <readline/readline.h> > > # include <readline/history.h> > > #endif > > How common is it for library .h files to assume autotools-style HAVE_* > and WITH_* flags are defined? I'm just wondering if this particular > failure is just one instance that's indicating a more general problem. It looks like Wireshark also assumes you're using autotools: https://www.redhat.com/archives/libvir-list/2020-September/msg00156.html I would consider it a bug in the library. -- Andrea Bolognani / Red Hat / Virtualization
