Re: [PATCH 1/5] qemu_domain.c: make qemuDomainGetMemorySizeAlignment() public

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 7/30/20 9:48 PM, Daniel Henrique Barboza wrote:
> Next patch will use it outside of qemu_domain.c.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
> ---
>   src/qemu/qemu_domain.c | 2 +-
>   src/qemu/qemu_domain.h | 3 +++
>   2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 2058290870..dfe3c3b64b 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -7939,7 +7939,7 @@ qemuDomainAgentAvailable(virDomainObjPtr vm,
>   }
>   
>   
> -static unsigned long long
> +unsigned long long
>   qemuDomainGetMemorySizeAlignment(virDomainDefPtr def)
>   {
>       /* PPC requires the memory sizes to be rounded to 256MiB increments, so
> diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
> index 29849a7313..cbd56861da 100644
> --- a/src/qemu/qemu_domain.h
> +++ b/src/qemu/qemu_domain.h
> @@ -989,6 +989,9 @@ qemuDomainFixupCPUs(virDomainObjPtr vm,
>   char *
>   qemuDomainGetMachineName(virDomainObjPtr vm);
>   
> +unsigned long long
> +qemuDomainGetMemorySizeAlignment(virDomainDefPtr def);
> +
>   void
>   qemuDomainObjPrivateXMLFormatAllowReboot(virBufferPtr buf,
>                                            virTristateBool allowReboot);

Nitpick, this header declaration could be moved a couple of lines down, 
next to qemuDomainAlignMemorySizes() which is also close in .c file :-)

Michal