Re: [PATCH 0/5] qemu: split off snapshot code for cleanup and reuse

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 8/6/20 11:55 AM, Peter Krempa wrote:
> Peter Krempa (5):
>    qemuOpenFileAs: Move into util/virqemu.c
>    qemuOpenFile: Move to qemu_domain.c
>    qemuFileWrapperFDClose: move to qemu_domain.c
>    qemu: Split of code related to handling of the save image file
>    qemu: Extract snapshot related code to a separate file
>
>   po/POTFILES.in            |    2 +
>   src/libvirt_private.syms  |    1 +
>   src/qemu/meson.build      |    2 +
>   src/qemu/qemu_domain.c    |   70 +
>   src/qemu/qemu_domain.h    |   11 +
>   src/qemu/qemu_driver.c    | 3320 ++-----------------------------------
>   src/qemu/qemu_saveimage.c |  764 +++++++++
>   src/qemu/qemu_saveimage.h |  116 ++
>   src/qemu/qemu_snapshot.c  | 2266 +++++++++++++++++++++++++
>   src/qemu/qemu_snapshot.h  |   55 +
>   src/util/virqemu.c        |  130 ++
>   src/util/virqemu.h        |    7 +
>   12 files changed, 3520 insertions(+), 3224 deletions(-)
>   create mode 100644 src/qemu/qemu_saveimage.c
>   create mode 100644 src/qemu/qemu_saveimage.h
>   create mode 100644 src/qemu/qemu_snapshot.c
>   create mode 100644 src/qemu/qemu_snapshot.h

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal