On Wed, 2020-08-19 at 15:10 +0200, Pavel Hrdina wrote:
> On Wed, Aug 19, 2020 at 02:58:07PM +0200, Andrea Bolognani wrote:
> > > > We can add an option like it was proposed in V1 but with the following
> > > > changes. In meson.build we would have this:
> > > >
> > > > if get_option('rpath')
> > > > libvirt_rpath = libdir
> > > > else
> > > > libvirt_rpath = ''
> > > > endif
> > > >
> > > > and all places with install_rpath would use libvirt_rpath instead of
> > > > libdir directly and we would not have to have the craze if-else.
> > >
> > > Yeah that would be simpler.
> >
> > ... I don't think this would work: using
> >
> > install_rpath: ''
> >
> > will result in an empty RPATH being set, not in RPATH being missing.
> > So it's a different behavior than the one we want.
>
> I specifically tried this to make sure it works and also this is from
> meson code:
>
> self.install_rpath = kwargs.get('install_rpath', '')
>
> so yes it works.
I tried again and I stand corrected :)
I'll send a new patch in a minute.
--
Andrea Bolognani / Red Hat / Virtualization
