On Tue, Feb 02, 2010 at 03:20:43PM +0100, Daniel Veillard wrote:
> On Mon, Feb 01, 2010 at 06:39:33PM +0000, Daniel P. Berrange wrote:
> > Since QEMU startup uses the new -device argument, the hotplug
> > code needs todo the same. This converts disk, network and
> > host device hotplug to use the device_add command
> >
> > * src/qemu/qemu_driver.c: Use new device_add monitor APIs
> > whereever possible
> > ---
> [...]
> > + if (qemuCmdFlags & QEMUD_CMD_FLAG_DEVICE) {
> > + ret = qemuMonitorAddDrive(priv->mon, drivestr);
> > + if (ret == 0)
> > + qemuMonitorAddDevice(priv->mon, devstr);
> > + /* XXX remove the drive upon fail */
>
> Hum, maybe this small TODO should be added, hopefully it's in a later
> patch
>
> [...]
> > + if (ret == 0)
> > + ret = qemuMonitorAddDevice(priv->mon,
> > + devstr);
> > + /* XXX should call 'drive_del' on error but this does not exist yet */
>
> ah, that's why ...
>
> ACK,
I've got a bug open against QEMU to get a 'drive_del' command added.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list