2010/2/1 Daniel P. Berrange <berrange@xxxxxxxxxx>: > All the helper functions for building command line arguments > now return a 'char *', instead of acepting a 'char **' or > virBufferPtr argument > > * qemu/qemu_conf.c: Standardize syntax for building args > * qemu/qemu_conf.h: Export all functions for building args > * qemu/qemu_driver.c: Update for changed syntax for building > NIC/hostnet args > --- > diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h > index 2530813..b6f128f 100644 > --- a/src/qemu/qemu_conf.h > +++ b/src/qemu/qemu_conf.h > @@ -188,23 +188,51 @@ int qemudBuildCommandLine (virConnectPtr conn, > int *ntapfds, > const char *migrateFrom); > > -int qemuBuildHostNetStr (virConnectPtr conn, > - virDomainNetDefPtr net, > - char type_sep, > - int vlan, > - const char *tapfd, > - char **str); > +/* Legacy, pre device support */ > +char * qemuBuildHostNetStr(virConnectPtr conn, > + virDomainNetDefPtr net, > + char type_sep, > + int vlan, > + const char *tapfd); > > -int qemuBuildNicStr (virConnectPtr conn, > - virDomainNetDefPtr net, > - const char *prefix, > - int vlan, > - char **str); > +/* Current, best practice */ > +char * qemuBuildNetDevStr(virConnectPtr conn, > + virDomainNetDefPtr net, > + const char *tapfd); > + > + > +/* Legacy, pre device support */ > +char * qemuBuildNicStr(virConnectPtr conn, > + virDomainNetDefPtr net, > + const char *prefix, > + int vlan); > + > +/* Current, best practice */ > +char * qemuBuildNicDevStr(virDomainNetDefPtr net); > + > +/* Both legacy & current support support */ support support? > +char *qemuBuildDriveStr(virDomainDiskDefPtr disk, > + int bootable, > + int qemuCmdFlags); > + ACK. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list