On 8/3/20 1:29 PM, Peter Krempa wrote:
On Mon, Aug 03, 2020 at 19:18:53 +0200, Ján Tomko wrote:
Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
---
src/util/virbitmap.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c
index 4c205016ff..f7dd5d05ad 100644
--- a/src/util/virbitmap.c
+++ b/src/util/virbitmap.c
[...]
@@ -126,10 +121,9 @@ virBitmapNewEmpty(void)
void
virBitmapFree(virBitmapPtr bitmap)
{
- if (bitmap) {
- VIR_FREE(bitmap->map);
- VIR_FREE(bitmap);
- }
+ if (bitmap)
+ g_free(bitmap->map);
Preferrably keep this VIR_FREE or it's expansion to g_clear_pointer. If
a caller uses a stale pointer, it will crash on dereferencing this part.
This is an argument for NULLifying *all* pointers when they are freed
(yes, even things on the stack).
