On Mon, Aug 03, 2020 at 09:37:17AM +0200, Pavel Hrdina wrote: > On Wed, Jul 29, 2020 at 04:38:20PM +0200, Pavel Hrdina wrote: > > The second time around I will not post the complete series as it doesn't > > make that much sense. Instead I'll post a diff between the two series to > > provide the changes between these series together with links to both > > versions pushed to gitlab repository. > > > > Patches for v2 are available from my gitlab repository: > > > > git clone -b meson https://gitlab.com/phrdina/libvirt.git > > > > and link to gitlab pipeline: > > > > https://gitlab.com/phrdina/libvirt/-/pipelines/172042918 > > > > Patches for v1 are available from different branch 'meson-v1' in the > > same repository. You can get the attached diff by running: > > > > git diff meson-v1 meson > > Thanks for the review and all the feedback. I just pushed the patches to > master. I noticed a problem in a minimal build root, doesn't auto-disable ESX for some reason: meson.build:1607:2: ERROR: Problem encountered: Curl is required for the ESX driver Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|