Re: [libvirt PATCH 3/3] conf: scheduler parser: do not hardcode element name

[Pino Toscano <ptoscano@xxxxxxxxxx>]

On Monday, 27 July 2020 15:15:46 CEST Ján Tomko wrote:
> When trying to parse an XML with overlapping iothread scheduler
> settings, the error message was rather confusing:
> 
>    error: iothreadssched attributes 'vcpus' must not overlap
> 
> Pass the correct element name.
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 0f12b54575..1179a27a00 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -20024,8 +20024,8 @@ virDomainThreadSchedParseHelper(xmlNodePtr node,
>  
>          if (sched->policy != VIR_PROC_POLICY_NONE) {
>              virReportError(VIR_ERR_XML_DETAIL,
> -                           _("'%s' attributes 'vcpus' must not overlap"),
> -                           elementName);
> +                           _("'%s' attributes '%s' must not overlap"),
> +                           elementName, attributeName);

While I generally agree with this kind of changes, please note that
this is difficult in C: see:
https://www.gnu.org/software/gettext/manual/gettext.html#c_002dformat

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.