Re: [PATCH v1 12/34] qemuDomainNamespaceMknodPaths: Create more files in one go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Wednesday in 2020, Michal Privoznik wrote:
While the previous commit prepared the helper function run in a
forked off helper (with corresponding struct), this commit
modifies the caller, which now create all files requested in a
single process and does not fork off for every single path.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
src/qemu/qemu_domain_namespace.c | 89 ++++++++++++--------------------
1 file changed, 32 insertions(+), 57 deletions(-)

diff --git a/src/qemu/qemu_domain_namespace.c b/src/qemu/qemu_domain_namespace.c
index 31acf2bde6..b9f8c32770 100644
--- a/src/qemu/qemu_domain_namespace.c
+++ b/src/qemu/qemu_domain_namespace.c
@@ -1385,12 +1385,12 @@ qemuDomainMknodItemInit(qemuDomainMknodItemPtr item,


static int
-qemuDomainAttachDeviceMknodOne(qemuDomainMknodDataPtr data,
-                               virQEMUDriverConfigPtr cfg,
-                               virDomainObjPtr vm,
-                               const char *file,
-                               char * const *devMountsPath,
-                               size_t ndevMountsPath)
+qemuDomainNamespacePrepareOne(qemuDomainMknodDataPtr data,

Consider: PrepareItem or PrepareOneItem

+                              virQEMUDriverConfigPtr cfg,
+                              virDomainObjPtr vm,
+                              const char *file,
+                              char * const *devMountsPath,
+                              size_t ndevMountsPath)
{
    long ttl = sysconf(_SC_SYMLOOP_MAX);
    const char *next = file;

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux