Re: [libvirt PATCH 197/351] meson: src: add support for building daemon binaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 24, 2020 at 08:45:24AM +0200, Peter Krempa wrote:
> On Thu, Jul 16, 2020 at 11:57:13 +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> > ---
> >  src/meson.build            | 51 ++++++++++++++++++++++++++++++++++++++
> >  src/remote/Makefile.inc.am | 41 ------------------------------
> >  2 files changed, 51 insertions(+), 41 deletions(-)
> > 
> > diff --git a/src/meson.build b/src/meson.build
> > index 13f231f4345..3774e2bb4ba 100644
> > --- a/src/meson.build
> > +++ b/src/meson.build
> > @@ -131,6 +131,14 @@ libvirt_libs = []
> >  #   * install_dir - installation directory (optional, default libdir / 'libvirt' / 'connection-driver'
> >  virt_modules = []
> >  
> > +# virt_daemons:
> > +#   each entry is a dictionary with following items:
> > +#   * name - binary name (rquired)
> 
> required
> 
> > +#   * sources - binary sources (optional, default remote_daemon_sources)
> 
> I'd go with no default here, but I see it's used in many cases.

The default is used for almost all daemons except for virtlockd and
virtlogd where we use different sources. Otherwise the sources would not
be required at all.

Pavel

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux