On Wed, Jul 22, 2020 at 01:51:15PM -0400, Laine Stump wrote: > On 7/22/20 1:21 PM, Daniel P. Berrangé wrote: > > Historically we avoided -fstack-protector* since it resulted in a broken > > build on Mingw. In GCC 10 in Fedora though, we have the opposite problem, > > getting a broken build if we don't enable one of the -fstack-protector* > > options. This also works in GCC 9, so we don't need to worry about the > > old brokeness which evidentally got fixed at some time without noticing. > > > ...and I guess there's no "super old" mingw releases that we need to worry > about, since it's always the mingw on the current release of Fedora that's > used (did I get that right?) Yeah, we only try to build with currently shipping versions in Fedora. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
