On a Thursday in 2020, Pavel Hrdina wrote:
The PACKAGE* variables are defined by AC_INIT so we have to define explicitly with meson.
Interesting, it also defines PACKAGE_BUGREPORT, but instead we hardcode libvir-list@xxxxxxxxxx in a few error messages.
Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> --- autogen.sh | 53 ------------------ config.h | 1 + configure.ac | 96 --------------------------------- meson.build | 134 ++++++++++++++++++++++++++++++++++++++++++++++ meson_options.txt | 3 ++ 5 files changed, 138 insertions(+), 149 deletions(-) delete mode 100755 autogen.sh create mode 100644 config.h create mode 100644 meson.build create mode 100644 meson_options.txt
+# In libtool terminology we need to figure out:
This is one of the few mentions of libtool left after this series...
+# +# CURRENT +# The most recent interface number that this library implements. +# +# REVISION +# The implementation number of the CURRENT interface. +# +# AGE +# The difference between the newest and oldest interfaces that this +# library implements. +# +# In other words, the library implements all the interface numbers +# in the range from number `CURRENT - AGE' to `CURRENT'. +# +# Libtool assigns the soname version from `CURRENT - AGE', and we +# don't want that to ever change in libvirt. ie it must always be +# zero, to produce libvirt.so.0. +# +# We would, however, like the libvirt version number reflected +# in the so version'd symlinks, and this is based on AGE.REVISION +# eg libvirt.so.0.AGE.REVISION +# +# The following examples show what libtool will do +# +# Input: 0.9.14 -> libvirt.so.0.9.14 +# Input: 1.0.0 -> libvirt.so.0.1000.0 +# Input: 2.5.8 -> libvirt.so.0.2005.8 +# +# Assuming we do ever want to break soname version, this can +# toggled. But seriously, don't ever touch this.
... but this comment is very convicning. :)
+ +libvirt_so_version = 0 +libvirt_age = 1000 * arr_version[0].to_int() + arr_version[1].to_int() +libvirt_revision = arr_version[2].to_int() +libvirt_lib_version = '@0@.@1@.@2@'.format(libvirt_so_version, libvirt_age, libvirt_revision)
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
