On 7/16/20 9:20 AM, Peter Krempa wrote:
Ignore errors from creating "libvirt-tmp-activewrite" bitmap. This
prevents failures of finishing blockjobs if the bitmap already exists.
Note that if the bitmap exists, the worst case that can happen is that
more bits are marked as dirty in the resulting merge.
In turn, your incremental backup might be larger than it needs to be,
but you have not lost any data. I agree this is safe.
Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 348ef17141..64ddc8dce9 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17414,7 +17414,7 @@ qemuDomainBlockPivot(virQEMUDriverPtr driver,
}
if (bitmapactions && rc == 0)
- rc = qemuMonitorTransaction(priv->mon, &bitmapactions);
+ ignore_value(qemuMonitorTransaction(priv->mon, &bitmapactions));
if (rc == 0)
ret = qemuMonitorJobComplete(priv->mon, job->name);
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
