On Fri, Jul 17, 2020 at 03:45:36PM +0200, Peter Krempa wrote: > On Fri, Jul 17, 2020 at 11:39:15 +0200, Pavel Hrdina wrote: > > On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > > > > > [...] > > > > > > Tests fail when building with clang: > > > > > > built as: > > > > > > CC=clang meson clang ~/libvirt > > > cd clang > > > ninja > > > ninja test > > > > > > > > > Looking at the test output (pasted below) you didn't faithfully > > > reproduce the skipping of symbol file tests which have different > > > ordering when the code is compiled with clang. > > > > Nice catch, thanks. I tried building it with clang but did not try > > running tests. Should have tried running ninja dist. > > The fixed version on your branch now doesn't execute the tests when > building with clang. With autoconf they were silently skipped so I decided to not run them at all, but we can change it to show the as skipped. > After some learning curve (e.g. using -Dsystem=true to do the equivalent > of ./autogen.sh --system, and the .libs/ directory stopping to exist > I've successfully built both my normal workflows. Glad to hear that it works for someone else as well. Thanks for testing and the feedback. Pavel
Attachment:
signature.asc
Description: PGP signature