On Fri, Jul 17, 2020 at 12:06:54PM +0200, Ján Tomko wrote: > On a Friday in 2020, Pavel Hrdina wrote: > > On Fri, Jul 17, 2020 at 11:21:56AM +0200, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:53:56 +0200, Pavel Hrdina wrote: > > > > > > [...] > > > > > > Tests fail when building with clang: > > > > > > built as: > > > > > > CC=clang meson clang ~/libvirt > > > cd clang > > > ninja > > > ninja test > > > > > > > > > Looking at the test output (pasted below) you didn't faithfully > > > reproduce the skipping of symbol file tests which have different > > > ordering when the code is compiled with clang. > > > > Nice catch, thanks. I tried building it with clang but did not try > > running tests. > > Umm, how did the pipeline pass then, do we not run tests? We only use clang on FreeBSD & macOS and don't run unit tests on either. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|