On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > Patches are available in my Gitlab repo as well: > > git clone -b meson https://gitlab.com/phrdina/libvirt.git > > and link to Giltab pipeline: > > https://gitlab.com/phrdina/libvirt/-/pipelines/167276632 > > The pipeline is not for the latest version is I tweaked some commit > messages. BTW, assuming we do positively review this, we need to consider when is a good time to merge. Having positive CI builds is good, but that only tells us that a build succeeded, it doesn't tell us that all the right features are enabled. I think it is inevitable that we are going to break stuff and miss it in review. So the prudent approach would be to merge this series immediately after a release, so that we have as much of a full month available as possible for debugging post-merge. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
