Re: [PATCHv2 0/2] Add a type attribute on the mac address element

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 7/13/20 4:28 PM, Bastien Orivel wrote:
> Changed:
>      - Split the commit in two to separate the documentation from the
>        code changes.
>      - Change the attribute name from check (tri state bool) to type
>        (static/generated).
>
> This time with the patches too...
>
> Bastien Orivel (2):
>    Add a type attribute on the mac address element
>    Document the `type` attribute for mac addresses
>
>   NEWS.rst                                      |  6 ++++
>   docs/drvesx.html.in                           |  7 +++++
>   docs/schemas/domaincommon.rng                 |  8 +++++
>   src/conf/domain_conf.c                        | 26 ++++++++++++++++-
>   src/conf/domain_conf.h                        | 11 +++++++
>   src/vmx/vmx.c                                 |  8 +++--
>   .../network-interface-mac-type.xml            | 29 +++++++++++++++++++
>   tests/genericxml2xmltest.c                    |  2 ++
>   8 files changed, 93 insertions(+), 4 deletions(-)
>   create mode 100644 tests/genericxml2xmlindata/network-interface-mac-type.xml

I'm fixing all the small nits I've raised in my review, and pushing.

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal