On a Wednesday in 2020, Erik Skultety wrote:
On Wed, Jul 08, 2020 at 01:28:49PM +0200, Ján Tomko wrote:On a Wednesday in 2020, Erik Skultety wrote: > I overlooked this typo during review of 2c3ffa37. Please do not follow commit hashes directly by a period. * rephrase the sentence * just drop the period * include a separator like <> or put in into the Fixes: tagI remember you used to oppose the idea of using the Fixes/Resolves tags in commit messages and be quite adamant about it,
I objected to their usage with links to bugzilla, since the word seems
redundant in combination with a bugzilla link (especially since it is
only intended for human consumption). Or, if you say 'Resolves'
on a preparatory patch, you're actually lying in the current commit
message.
Plain https: links mess with git's interpret-trailers functionality,
but that can be worked around in your .gitconfig:
[trailer "https"]
key = https:
ifExists = doNothing
With commit message IDs, if you dropped a plain one without a context,
I would not know whether you find a bug in it, or just took it as an
inspiration.
so looks strange you would suggest it.
I've known you for a few years now, surely there would be other things by now I've had a change of heart about. :) Jano
Anyhow, noted, I forgot that the period breaks the double click selection of the hash. Erik
Attachment:
signature.asc
Description: PGP signature
