Re: [GSoC][PATCH v2] qemu_domainjob: removal of its dependency on other qemu-files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/8/20 8:33 PM, Prathamesh Chavan wrote:
It was seen that `qemu_domain.h` file depended upon
`qemu_migration_params.h` and `qmeu_monitor.h` as they
were required by some qemu_domainjob stuctures.
This dependency was removed by the introduction of
a `void *privateData` pointer. This privateData pointer
was handled using a structure of callback functions.

Additionally, the patch also moves funcitons
`qemuDomainObjPrivateXMLFormatJob` and
`qemuDomainObjPrivateXMLParseJob` from `qemu_domain`
and handles them using the callback structure of
domain jobs.

Signed-off-by: Prathamesh Chavan <pc44800@xxxxxxxxx>
---
Previous version of this patch can be found here[1].

This patch adds a funciton to the domainJobInfo callback
structure to specifically to copy the jobInfo privateData
structure.

Also, it was noticed that qemuDomainNamespace was reciding
in `qmeu_domainjob.c`, and should rather be in its original file
`qmeu_domain.c`. hence was moved.

  src/qemu/qemu_backup.c           |  13 +-
  src/qemu/qemu_domain.c           | 251 +-------------------
  src/qemu/qemu_domainjob.c        | 386 ++++++++++++++++++++++++++++---
  src/qemu/qemu_domainjob.h        |  69 ++++--
  src/qemu/qemu_driver.c           |  21 +-
  src/qemu/qemu_migration.c        |  45 ++--
  src/qemu/qemu_migration_cookie.c |   7 +-
  src/qemu/qemu_migration_params.c |   9 +-
  src/qemu/qemu_migration_params.h |  28 +++
  src/qemu/qemu_process.c          |  24 +-
  10 files changed, 515 insertions(+), 338 deletions(-)

This is very large change. Can it be split into smaller patches so that it is easier to review? There are several things happening at the same time hence I think it should be possible.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux