On a Wednesday in 2020, Ján Tomko wrote:
On a Wednesday in 2020, Peter Krempa wrote:Commit 82576d8f35e used a string "on" to enable the 'pmem' property. This is okay for the command line visitor, but the property is declared as boolean in qemu and thus it will not work when using QMP. Modify the type to boolean. This changes the command line, but fortunately the command line visitor in qemu parses both 'yes' and 'on' as true for the property. https://bugzilla.redhat.com/show_bug.cgi?id=1854684 Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> --- src/qemu/qemu_command.c | 2 +- .../memory-hotplug-nvdimm-pmem.x86_64-latest.args | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
I meant to paste: Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> somewhere in here. Jano
Attachment:
signature.asc
Description: PGP signature
