On Fri, Jul 03, 2020 at 03:13:29PM +0200, Michal Privoznik wrote: > On 7/3/20 2:08 PM, Ján Tomko wrote: > > On a Friday in 2020, Michal Privoznik wrote: > > > This function will be used to detect zero buffers (which are > > > going to be interpreted as hole in virStream later). > > > > > > I shamelessly took inspiration from coreutils. > > > > > > > How is that okay, isn't coreutils GPL-licensed? > > Well, I only took inspiration in that code, I haven't copied it. > But this idea of using memcmp() is quite old and described for instance in > this blog post too: > > https://rusty.ozlabs.org/?p=560 > > Do you want to switch to something else instead? If so, how can we make sure > it's not already somewhere in a code with incompatible license? I think the current code is fine as it is simple logic. If someone described the algorithm you'd end up doing it the same way Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
