On Wed, Jul 01, 2020 at 12:07:13AM +0800, Shi Lei wrote: > >On Wed, Jun 10, 2020 at 09:20:33AM +0800, Shi Lei wrote: > >> Add these helper functions to parse xml without using xmlXPathContext. > >> > >> Signed-off-by: Shi Lei <shi_lei@xxxxxxxxxxxxxx> > >> --- > >> src/util/virxml.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++ > >> src/util/virxml.h | 3 +++ > >> 2 files changed, 60 insertions(+) > > > >Should be added to src/libvirt_private.syms too > > I wonder why we need to do this?! Your particular series doesn't need it, but in general any internal function that ends up in libvirt.so needs to be added to the libvirt_private.syms file. This makes it possible to call the function from the dlopen'd modules like libvirt_driver_qemu.so. So we always add to the libvirt_private.syums file, even if we don't technically need that right now. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
