On 6/29/20 5:44 AM, Andrea Bolognani wrote:
On Sun, 2020-06-28 at 09:25 -0300, Daniel Henrique Barboza wrote:
On 6/27/20 10:32 AM, Andrea Bolognani wrote:
In the future, please don't include CC tags in your commits: removing
them results in extra work when picking up a patch, and it's also
generally not considered very polite to CC individual developers.
Everyone is subscribed to the list anyway :)
I screwed up with the CC: tags in the commit msg. I usually do it via
"--cc" in git-sendpatch in these cases.
As for not being polite, I CC'ed the people that was related with the
commit that I was fixing (signed-off/reviewed-by). Perhaps I should
have CC'ed just the author instead .... assuming that CC'ing the author
of the commit I'm amending is OK here in Libvirt, of course. At least
in the QEMU mailing list it's not just OK, but encouraged to CC the
author of the commit you're fixing to make the person aware.
QEMU and libvirt are different projects, which follow different
conventions in many areas such as coding style, merge workflow, and
mailing list usage.
For libvirt specifically, our documentation[1] states
As a rule, patches should be sent to the mailing list only: all
developers are subscribed to libvir-list and read it regularly, so
**please don't CC individual developers** unless they've explicitly
asked you to.
Got it. I suppose this rule will stay the same after we move to Gitlab,
which makes me a bit nervous. Today I can ask people to put me in the CC
if they're fixing/reverting a commit I've authored, but I don't know if
this is possible at all with pull requests.
Thanks,
DHB
[1] https://libvirt.org/submitting-patches.html
