Re: [PATCH 10/25] network: convert local pointers to g_auto*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Wednesday in 2020, Laine Stump wrote:
This includes those that use plain VIR_FREE() as well as those that
have a cleanup function defined for use via g_auto/g_autoptr
(virCommand, virFirewall, virBuffer, virJSONValue etc).

Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
---
src/network/bridge_driver.c       | 477 +++++++++++-------------------
src/network/bridge_driver_linux.c |  55 ++--
src/network/leaseshelper.c        |  16 +-
src/util/virdnsmasq.h             |   4 +
4 files changed, 209 insertions(+), 343 deletions(-)


Since this patch touches way too many functions, it would be much easier
to read in two separate commits:
1) add g_auto markers and remove the corresponding VIR_FREE's, possibly
   leaving empty cleanup sections
2) removing all the now unnecessary labels and gotos

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux