On Wed, Jun 24, 2020 at 09:35:22 -0500, Eric Blake wrote: > On 6/24/20 9:07 AM, Peter Krempa wrote: > > oVirt does merge images out of libvirt in some cases. Add docs outlining > > how it's done from a high level. > > > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > > --- > > docs/kbase/incrementalbackupinternals.rst | 37 +++++++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > > > diff --git a/docs/kbase/incrementalbackupinternals.rst b/docs/kbase/incrementalbackupinternals.rst > > index 9a96ef6df3..e50bf52e89 100644 > > --- a/docs/kbase/incrementalbackupinternals.rst > > +++ b/docs/kbase/incrementalbackupinternals.rst > > @@ -245,3 +245,40 @@ the snapshot. > > continue > > > > create RECORDING bitmap named BITMAP in OVERLAY with GRANULARITY > > + > > +Commiting external snapshots manually > > Committing > > > +------------------------------------- > > + > > +``block commit`` refers to an operation where data from a subchain of the > > +backing chain is merged down into the backing image of the subchain removing all > > +images in the subchain . > > Drop space before . > > Does oVirt care about block pull, or only block commit? But block pull can > be a separate patch if we need more information; this one is useful as-is > (well, with typos fixed). oVirt doesn't use block pull for now and even libvirt doesn't implement bitmap handling for the pull job for now. I'll add information here once I do the implementation.