Re: [PATCH libvirt-dbus 1/3] src: fix double free of virDomain object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-06-24 at 16:17 +0100, Daniel P. Berrangé wrote:
> The virDomainSnapshotGetDomain() method does NOT increment the
> refcount on the returned virDomain, so it must not be unrefed.
> 
> This double free is responsible for random failures of the
> test_snapshot.py tests.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  src/domainsnapshot.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Nice!

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux