On Mon, Jun 22, 2020 at 04:43:21PM -0500, Jonathon Jongsma wrote: > It's possible to use ramfb as the boot display of an assigned vgpu > device. This was introduced in 4b95738c, but unfortunately the attribute > was not formatted into the xml output for such a device. This patch > fixes that oversight and adds a xml2xml test to verify proper behavior. > > https://bugzilla.redhat.com/show_bug.cgi?id=1847791 > > Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> > --- ... > diff --git a/tests/qemuxml2xmloutdata/hostdev-mdev-display-ramfb.xml b/tests/qemuxml2xmloutdata/hostdev-mdev-display-ramfb.xml > new file mode 100644 > index 0000000000..6fdc477ca2 > --- /dev/null > +++ b/tests/qemuxml2xmloutdata/hostdev-mdev-display-ramfb.xml You don't need this one since you only test with the latest capabilities, so you? With that file dropped: Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx> > @@ -0,0 +1,33 @@ > +<domain type='qemu'> > + <name>QEMUGuest2</name> > + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> > + <memory unit='KiB'>219136</memory> > + <currentMemory unit='KiB'>219136</currentMemory> > + <vcpu placement='static'>1</vcpu> > + <os> > + <type arch='i686' machine='pc'>hvm</type> > + <boot dev='hd'/> > + </os> > + <clock offset='utc'/> > + <on_poweroff>destroy</on_poweroff> > + <on_reboot>restart</on_reboot> > + <on_crash>destroy</on_crash> > + <devices> > + <emulator>/usr/bin/qemu-system-i386</emulator> > + <controller type='usb' index='0'> > + </controller> > + <controller type='pci' index='0' model='pci-root'/> > + <controller type='ide' index='0'> > + </controller> > + <graphics type='vnc'/> > + <hostdev mode='subsystem' type='mdev' model='vfio-pci' display='on' ramfb='on'> > + <source> > + <address uuid='53764d0e-85a0-42b4-af5c-2046b460b1dc'/> > + </source> > + </hostdev> > + <video> > + <model type='qxl' heads='1'/> > + </video> > + <memballoon model='none'/> > + </devices> > +</domain>
