On 6/9/20 10:00 AM, Peter Krempa wrote:
With the upcoming changes to use 'dirty-bitmap-populate' job, this will no longer be required to do the backups, so we can stop creating bitmaps which would be pointless.
Even if qemu 5.1 adds block-dirty-bitmap-populate, don't we still want to keep supporting qemu 5.0 where it was not present, and therefore need code for propagating bitmaps during snapshot creation? Or is the plan that you won't enable incremental backup support in libvirt unless you detect new enough qemu including bitmap-populate support?
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
