On Fri, Jun 19, 2020 at 11:56:07AM +0200, Peter Krempa wrote:
> On Fri, Jun 19, 2020 at 10:32:43 +0100, Daniel Berrange wrote:
> > We can't change the term used by scsi_id for its CLI arg, but
> > we can avoid it by picking the short form instead.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> > src/util/virstoragefile.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
> > index a6357abb08..b4337c2736 100644
> > --- a/src/util/virstoragefile.c
> > +++ b/src/util/virstoragefile.c
> > @@ -1365,7 +1365,7 @@ virStorageFileGetSCSIKey(const char *path,
> >
> > cmd = virCommandNewArgList("/lib/udev/scsi_id",
> > "--replace-whitespace",
> > - "--whitelisted",
> > + "-g",
>
> IMO this decreases the readability of the code.
I agree, but I think that doesn't really matter in the big picture
as this is not code that is a serious maint burden in libvirt.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
