Re: [PATCH 23/32] qemu: backup: Rewrite backup bitmap handling to the new bitmap semantics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/15/20 12:10 PM, Peter Krempa wrote:
Reuse qemuBlockGetBitmapMergeActions which allows to remove the ad-hoc

allows the removal of the

iplementatio of bitmap merging for backup. The new approach is simpler

implementation

and also more robust in case some of the bitmaps break as they remove
the dependancy on the whole chain of bitmaps working.

dependency


The new approach also allows backups if a snapshot is created outside of
libvirt.

Additionally the code is greatly simplified.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
  src/qemu/qemu_backup.c                        | 220 +++---------------
  src/qemu/qemu_backup.h                        |  12 +-
  tests/qemublocktest.c                         |  86 ++-----
  .../backupmerge/empty-out.json                |   4 +-
  4 files changed, 63 insertions(+), 259 deletions(-)

Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux