Re: [libvirt PATCH] Fix allocation of virDomainFSDef

[Ján Tomko <jtomko@xxxxxxxxxx>]

On a Thursday in 2020, Andrea Bolognani wrote:
> On Thu, 2020-06-18 at 14:13 +0200, Ján Tomko wrote:
> > Some less commonly used drivers were omitted when we switched
> > the allocator from a plain VIR_ALLOC to virDomainFSDefNew.
> >
> > Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> > Fixes: da665fbd4858890fbb3bbf5da2a7b6ca37bb3220
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1846450
>
> The S-o-b tag is traditionally the last one to appear in the commit
> message. Do you have a reason for having it up there?

Of course!

Jano


See https://www.redhat.com/archives/libvir-list/2020-June/msg00710.html
for my reasoning.

> If not, please
> move it to the bottom of the commit message and add my
>
>  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
>
> too while you're at it :)
>
> --
> Andrea Bolognani / Red Hat / Virtualization

Attachment: signature.asc
Description: PGP signature