On Tue, 2020-06-16 at 19:53 +0200, Erik Skultety wrote: > On Tue, Jun 16, 2020 at 07:23:40PM +0200, Erik Skultety wrote: > > On Tue, Jun 16, 2020 at 09:27:48AM -0500, Jonathon Jongsma wrote: > > > This is the first portion of an effort to support persistent > > > mediated devices > > > with libvirt. This first series simply enables creating and > > > destroying > > > non-persistent mediated devices via the virNodeDeviceCreateXML() > > > and > > > virNodeDeviceDestroy() functions. The 'mdevctl' utility[1] > > > provides the backend > > > implementation. > > > > > > Changes in v3: > > > - Includes all of the changes mentioned by Michal > > > - makes iommuGroup element optional for the nodedev schema (per > > > Erik) > > > - substitutes a placeholder for the path to the mdevctl binary > > > before > > > comparing to the expected output > > > > So, looks like that the gitlab pipeline doesn't like your changes > > https://gitlab.com/eskultety/libvirt/-/pipelines/156830100 > > > > However, I can run the same thing locally with > > "make -C ci ci-check@fedora-31" successfully as well as on bare > > metal without > > mdevctl installed, so I'll have to look into that more closely > > what's going on, > > this is merely an FYI if you don't run your builds in gitlab by any > > chance. If > > Got it. I forgot that gitlab is running distcheck whereas the > containers from > the ci/ directory only run "check" (there's only ci-check command). > You're > missing "nodedevmdevctldata" in the EXTRA_DIST list in > tests/Makefile.am > > Regards, > Erik This is a good reminder, thanks. I have not been pushing my WIP branches to gitlab, so I haven't been running the gitlab CI. Jonathon
