Re: [libvirt] [PATCH] Use virFileResolveLink instead of readlink in AppArmor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/1/21 Jamie Strandboge <jamie@xxxxxxxxxxxxx>:
> Was this patch tested? I initially tried to use virFileResolveLink() but
> could not. This was discussed in "[libvirt] [PATCH 0/4] AppArmor
> updates" from 11/12/2009:
>
> "Implements all changes requested by DV except for getting rid of
> readlink(). I can't use virFileResolveLink() because it lstat()s the
> file and uses st.st_size to create a buffer. Unfortunately, running
> lstat() on /proc/self/exe results in st.st_size to be 0."
>
> Unless virFileResolveLink() was changed, this patch will break AppArmor.
>
> Jamie
>
> --
> Jamie Strandboge             | http://www.canonical.com
>

I think Jim Meyering fixed virFileResolveLink, see:

http://libvirt.org/git/?p=libvirt.git;a=commit;h=5baa463541d9081d43e86237e88d3041b4ae6338

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]