Re: [libvirt PATCH v2 0/4] ci: Use GitLab container registry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-06-10 at 11:19 +0100, Daniel P. Berrangé wrote:
> On Tue, Jun 02, 2020 at 05:28:54PM +0200, Andrea Bolognani wrote:
> > Changes from [v1]:
> > 
> > * only build containers necessary for extra jobs when said jobs
> >   are actually going to run;
> > 
> > * rename container build jobs to '$arch-$os-container';
> > 
> > * rename 'other' stage to 'preliminary_checks' and move it before
> >   native builds;
> > 
> > * simplify build system integration.
> > 
> > 
> > [v1] https://www.redhat.com/archives/libvir-list/2020-May/msg01183.html
> > 
> > Andrea Bolognani (4):
> >   ci: Use variables to build image names
> >   ci: Add 'preliminary_checks' stage
> >   ci: Use GitLab container registry
> >   ci: Update build system integration
> 
> Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>

Thanks, but in addition to the obvious need to rebase on top of
master I have some other changes that I have either already made
locally or plan to make later, so I'll respin.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux