On Mon, 2020-06-08 at 15:54 +0100, Daniel P. Berrangé wrote: > The general goal is that the CI jobs are self-contained and don't > depend on the build artifacts from the libvirt repo. We also want > to avoid having an explicit dependency on the libvirt-ci repo, or > on the Quay.io service. Contributors to the PHP module need to be s/PHP/TCK/ > Neither CentOS nor Ubuntu have the required perl deps to run the > TCK so those platforms are currently skipped. You should also mention openSUSE here, since you are excluding that platform as well for what I assume are the same reasons. > +.container_job_template: &container_job_definition > + image: docker:stable > + stage: containers > + services: > + - docker:dind > + before_script: > + - export TAG="$CI_REGISTRY_IMAGE/ci-$NAME:latest" > + - export COMMON_TAG="$CI_REGISTRY/libvirt/libvirt-perl/ci-$NAME:latest" s/perl/tck/ With these nits fixed, Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization
