On Wed, Jan 20, 2010 at 03:15:05PM +0000, Daniel P. Berrange wrote: > If there is a problem with VM startup, PCI devices may be left > assigned to pci-stub / pci-back. Adding a call to reattach > host devices in the cleanup path is required. > > * qemu/qemu_driver.c: qemuDomainReAttachHostDevices() when > VM startup fails > --- > src/qemu/qemu_driver.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 9554852..22b6adc 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -2742,6 +2742,8 @@ cleanup: > /* We jump here if we failed to start the VM for any reason > * XXX investigate if we can kill this block and safely call > * qemudShutdownVMDaemon even though no PID is running */ > + qemuDomainReAttachHostDevices(conn, driver, vm->def); > + > if (driver->securityDriver && > driver->securityDriver->domainRestoreSecurityAllLabel) > driver->securityDriver->domainRestoreSecurityAllLabel(conn, vm); ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list