Re: [libvirt PATCH 4/5] ci: Update build system integration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2020-06-02 at 11:36 +0100, Daniel P. Berrangé wrote:
> On Fri, May 29, 2020 at 03:00:43PM +0200, Andrea Bolognani wrote:
> > +# Registry where container images are stored
> > +CI_IMAGE_REGISTRY = registry.gitlab.com
> > +
> >  # Location of the container images we're going to pull
> >  # Can be useful to overridde to use a locally built
> >  # image instead
> > -CI_IMAGE_PREFIX = quay.io/libvirt/buildenv-libvirt-
> > +CI_IMAGE_PREFIX = libvirt/libvirt/ci-
> 
[...]
> 
> >  ci-run-command@%: ci-prepare-tree
> > -	$(CI_ENGINE) run $(CI_ENGINE_ARGS) $(CI_IMAGE_PREFIX)$*$(CI_IMAGE_TAG) \
> > +	image=; \
> > +	if test "$(CI_IMAGE_REGISTRY)"; then \
> 
> What condition is this expected to be testing ?

The case where someone built a (possibly custom) image locally and
wants to use it with something like

  $ make ci-build@centos-8 \
         CI_IMAGE_REGISTRY= \
         CI_IMAGE_PREFIX=my-

This usage scenario is explicity called out in the comment for the
CI_IMAGE_PREFIX variable.

But, I just realized I can avoid introducing CI_IMAGE_PREFIX by
changing the code slightly in ci/list-images.sh, so I'll do that
instead and avoid the extra complexity.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux