On Thu, May 21, 2020 at 04:05:47PM +0800, Han Han wrote: > On Thu, May 21, 2020 at 2:44 PM Peter Krempa <pkrempa@xxxxxxxxxx> wrote: > > > On Thu, May 21, 2020 at 14:08:17 +0800, Han Han wrote: > > > Let's drop tftp support since it is ususabled before or after QEMU v2.8 > > > [1]. > > > > > > [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1372143 > > > > > > > > > Han Han (3): > > > docs: Remove tftp protocol support from docs > > > src: Remove tftp network storage support > > > news: Remove support for tftp storage protocol > > > > NACK series: > > > > 1) qemu 2.8 is still supported by libvirt > > > However, the tftp is actually unusable for all versions of qemu, while the > formatdomain doc > states that it is optional protocol Do you have any more information on this. I'd be surprised if it was /always/ unusuable, as opposed to initially working and then getting broken in some particular version of QEMU. > > > 2) we can't remove XML parser support for previously supported XMLs as > > the existing defined VMs would vanish. That's exactly why the check in > > my patch was added into the validator which doesn't validate existing > > defined configs. > > > I understand the consideration of the compatibility. How about only > removing it from docs? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
