Re: [PATCH 1/3] docs: Remove tftp protocol support from docs

[Peter Krempa <pkrempa@xxxxxxxxxx>]

On Thu, May 21, 2020 at 14:08:18 +0800, Han Han wrote:
> Signed-off-by: Han Han <hhan@xxxxxxxxxx>
> ---
>  docs/formatdomain.html.in     | 10 +---------
>  docs/schemas/domaincommon.rng |  1 -
>  2 files changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 23eb0292..cadb64b2 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -2952,14 +2952,6 @@
>      &lt;target dev='hdh' bus='ide' tray='open'/&gt;
>      &lt;readonly/&gt;
>    &lt;/disk&gt;
> -  &lt;disk type='network' device='cdrom'&gt;
> -    &lt;driver name='qemu' type='raw'/&gt;
> -    &lt;source protocol="tftp" name="url_path"&gt;
> -      &lt;host name="hostname" port="69"/&gt;
> -    &lt;/source&gt;
> -    &lt;target dev='hdi' bus='ide' tray='open'/&gt;
> -    &lt;readonly/&gt;
> -  &lt;/disk&gt;
>    &lt;disk type='block' device='lun'&gt;
>      &lt;driver name='qemu' type='raw'/&gt;
>      &lt;source dev='/dev/sda'&gt;
> @@ -3166,7 +3158,7 @@
>                The <code>protocol</code> attribute specifies the protocol to
>                access to the requested image. Possible values are "nbd",
>                "iscsi", "rbd", "sheepdog", "gluster", "vxhs", "http", "https",
> -              "ftp", ftps", or "tftp".
> +              "ftp", ftps".
>  
>                <p>For any <code>protocol</code> other than <code>nbd</code>
>                an additional attribute <code>name</code>

We theoretically can remove the example and state that 'tftp' didn't
really work.


> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 9d60b090..c93b150d 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1942,7 +1942,6 @@
>            <choice>
>              <value>sheepdog</value>
>              <value>ftp</value>
> -            <value>tftp</value>
>            </choice>

But we can't do this.

>          </attribute>
>          <attribute name="name"/>
> -- 
> 2.25.0
>