Re: [PATCH trivial v2 1/1] logging.html.in: fix number of output formats available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2020-05-19 at 18:41 -0300, Daniel Henrique Barboza wrote:
> [PATCH trivial v2 1/1] logging.html.in: fix number of output formats available

We don't usually put "trivial" or anything like that in the patch
subject. You're also supposed to prefix the word "PATCH" with the
name of the project you're targeting, but with most sub-projects
moving to a merge request workflow that's probably not that critical
anymore.

> There are 4 formats available (x:stderr, x:syslog:name,
> x:file:file_path, x:journald), not 3. Use "the following"
> instead of the actual number to avoid the need to update
> the number every time a new form is added/removed.
> 
> Suggested-by: Pino Toscano <ptoscano@xxxxxxxxxx>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
> ---
>  docs/logging.html.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Anyway, the changes are good, so

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

and pushed.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux