Re: [libvirt PATCH 1/6] qemu: stop checking virObjectUnref return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/19/20 12:41 PM, Daniel P. Berrangé wrote:
Some, but not all, of the monitor event handlers check
the virObjectUnref return value to see if the domain
was disposed.

It should not be possible for this to happen, since
the functional ready holds a lock on the domain and

s/functional ready/function already/ (not everyday that a misplaced space still results in two valid words which might still legitimately appear adjacent in some other sentence...)

has only just acquired an extra reference on the
domain a few lines earlier.

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
  src/qemu/qemu_process.c | 30 ++++++++++++------------------
  1 file changed, 12 insertions(+), 18 deletions(-)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux