Re: [PATCH 08/15] testQEMUSchemaValidate(Command): Allow skipping validation of deprecated fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Wednesday in 2020, Peter Krempa wrote:
Some test cases are used to validate interactions with old qemu. We need
to skip validation of deprecation with those once it will be added.

In case of commands which were already replaced by code based on
capabilities we can skip the full validation once the command is
removed.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
tests/qemublocktest.c        | 14 +++++++-------
tests/qemumonitorjsontest.c  |  3 ++-
tests/qemumonitortestutils.c |  5 ++++-
tests/testutilsqemuschema.c  | 17 +++++++++++++++--
tests/testutilsqemuschema.h  |  3 +++
5 files changed, 31 insertions(+), 11 deletions(-)

@@ -508,16 +515,22 @@ testQEMUSchemaValidate(virJSONValuePtr obj,
 * -1 if it does not and -2 if there is a problem with the schema or with
 *  internals.
 *
+ * @alllowRemoved should generally be used only if it's certain that there's a

*allow

+ * replacement of @command in place.
+ *
 * @debug is filled with information regarding the validation process
 */
int
testQEMUSchemaValidateCommand(const char *command,
                              virJSONValuePtr arguments,
                              virHashTablePtr schema,

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux