On 15/05/20 16:35, Gerd Hoffmann wrote: > v2: > - use g_assert_not_reached() for stubs. > - add deprecation notice. If I understand it, the deprecation message suggests "-device ac97" instead of "-soundhw ac97", but that in turn relies on the deprecated default audiodev feature. So I'm not sure deprecating -soundhw is a good idea. Instead, is it possible to make "-soundhw foo" desugar to "-audiodev something,id=audio0 -global foo.audiodev=audio0 -device foo", where the "-device foo" would be omitted for isa-pcspk? It's all ad hoc, but that's the point of combined frontend/backend options like -nic. This doesn't change that libvirt can just stop using -soundhw just by looking for the isa-pcspk.audiodev property. Thanks, Paolo > Gerd Hoffmann (13): > stubs: add isa_create_simple > stubs: add pci_create_simple > audio: add deprecated_register_soundhw > audio: deprecate -soundhw ac97 > audio: deprecate -soundhw es1370 > audio: deprecate -soundhw adlib > audio: deprecate -soundhw cs4231a > audio: deprecate -soundhw gus > audio: deprecate -soundhw sb16 > audio: deprecate -soundhw hda > audio: deprecate -soundhw pcspk > audio: add soundhw deprecation notice > [RFC] audio: try use onboard audiodev for pcspk > > include/hw/audio/soundhw.h | 2 ++ > hw/audio/ac97.c | 9 ++------- > hw/audio/adlib.c | 8 +------- > hw/audio/cs4231a.c | 8 +------- > hw/audio/es1370.c | 9 ++------- > hw/audio/gus.c | 8 +------- > hw/audio/intel-hda.c | 3 +++ > hw/audio/pcspk.c | 27 ++++++++++++++++++++++++--- > hw/audio/sb16.c | 9 ++------- > hw/audio/soundhw.c | 24 +++++++++++++++++++++++- > qdev-monitor.c | 2 ++ > stubs/isa-bus.c | 7 +++++++ > stubs/pci-bus.c | 7 +++++++ > docs/system/deprecated.rst | 9 +++++++++ > stubs/Makefile.objs | 2 ++ > 15 files changed, 88 insertions(+), 46 deletions(-) > create mode 100644 stubs/isa-bus.c > create mode 100644 stubs/pci-bus.c >
