On 01/19/2010 10:51 AM, David Allan wrote:
This patch implements multiIQN support for iSCSI pools, allowing the user to specify the initiator IQN that should be used when creating the pool.
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
I realized after I sent this patch that I had left a potentially
dangerous debug message in it--the call to virArgvToString may return
NULL, but it's not really necessary in any case. The attached patch
removes the message.
Dave
>From 3f58f88a1797d823d53938e2fee3039dcef09f0c Mon Sep 17 00:00:00 2001
From: David Allan <dallan@xxxxxxxxxx>
Date: Tue, 19 Jan 2010 11:01:02 -0500
Subject: [PATCH 1/1] Remove potentially dangerous debug message
---
src/storage/storage_backend_iscsi.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c
index e0788cf..30022e8 100644
--- a/src/storage/storage_backend_iscsi.c
+++ b/src/storage/storage_backend_iscsi.c
@@ -363,8 +363,6 @@ virStorageBackendISCSIConnectionIQN(virConnectPtr conn,
ifacename, action, NULL
};
- VIR_DEBUG("cmdargv: '%s'", virArgvToString(cmdargv));
-
if (virRun(conn, cmdargv, NULL) < 0) {
virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
_("Failed to run command '%s' with action '%s'"),
--
1.6.5.5
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list