On Tue, 2020-05-12 at 10:51 +0100, Daniel P. Berrangé wrote: > This fixes a bugs from bit-rot and then enables GitLab CI and use of > merge requests for contribution. > > Daniel P. Berrangé (6): > Fix test driver connection type > Add workaround for broken screenshot API on Ubuntu 18.04 vintage > Remove reference to test.java file that was deleted I looked at these first three patches and didn't really see anything obviously wrong with them, so under the assumption that you know what you're doing and you've tested your changes properly, Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> to them. > rpm: skip junit tests in RHEL-8 build > gitlab: introduce CI jobs testing git master & distro libvirt > gitlab: add CONTRIBUTING.rst file to indicate use of merge requests These I already commented on separately. -- Andrea Bolognani / Red Hat / Virtualization
