On Mon, May 11, 2020 at 01:10:14PM +0200, Rafael Fonseca wrote: > > On Tue, 2020-04-21 at 15:26 +0100, Daniel P. Berrangé wrote: > > > Overall I'm not convinced there's any benefit to using the separate > > > dispose method in libvirt. > > I have an updated version with dispose merged back into finalize. I'm > just waiting for any other comments before sending the update. Go ahead and send it. The rest of the code looks pretty sane to me, but there's a huge amount of it to review, so I'd rather just review a v3 straight away, and then start to incrementally push patches as they are reviewed. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
