On Wed, Apr 22, 2020 at 15:11:18 +0800, ZhengZhenyu wrote: > Introduce virCPUarmData to virCPUData > > Signed-off-by: Zhenyu Zheng <zhengzhenyulixi@xxxxxxxxx> > --- > src/cpu/Makefile.inc.am | 1 + > src/cpu/cpu.h | 2 ++ > src/cpu/cpu_arm_data.h | 31 +++++++++++++++++++++++++++++++ > 3 files changed, 34 insertions(+) > create mode 100644 src/cpu/cpu_arm_data.h This patch needs to be the first one in the series and either the corresponding hunks from the following patch should be squashed here or the this and the following patch could be squashed into a single one. ... > diff --git a/src/cpu/cpu_arm_data.h b/src/cpu/cpu_arm_data.h > new file mode 100644 > index 0000000000..cf12ca8c2e > --- /dev/null > +++ b/src/cpu/cpu_arm_data.h > @@ -0,0 +1,31 @@ > +/* > + * cpu_arm_data.h: 64-bit arm CPU specific data > + * > + * Copyright (C) 2020 Huawei Technologies Co., Ltd. > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; If not, see > + * <http://www.gnu.org/licenses/>. > + * > + */ > + > +#pragma once > + > +#define VIR_CPU_ARM_DATA_INIT { 0 } > + > +typedef struct _virCPUarmData virCPUarmData; > +struct _virCPUarmData { > + unsigned long vendor_id; > + unsigned long pvr; > + char *features; Make this a list of strings: char **features; > +}; Jirka