Re: [libvirt PATCH v2] docs: introduce a page showing a overall CI dashboard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 07, 2020 at 07:08:52PM +0200, Andrea Bolognani wrote:
> On Thu, 2020-05-07 at 15:29 +0100, Daniel P. Berrangé wrote:
> > +   * - ruby-libvirt
> > +     - .. image:: https://gitlab.com/libvirt/ruby-libvirt/badges/master/pipeline.svg
> > +          :target: https://gitlab.com/libvirt/ruby-libvirt/pipelines
> > +          :alt: ruby-libvirt pipeline status
> 
> Seriously though, why is this one not called libvirt-ruby? :)

I'd consider it mostly a historical accident. The actual tarball created
is ruby-libvirt-$VER.tar.gz, so the repo follows that.

For the perl though, we're call perl-Sys-Virt-$VER.tar.gz, but the repo
is libvirt-perl.

I've almost renamed the Ruby repo on a number of occassions but never
went through with it.

> 
> > +++ b/docs/libvirt.css
> > @@ -592,3 +592,8 @@ td.gitmirror {
> >  td.gitmirror a {
> >      color: inherit;
> >  }
> > +
> > +th p, td p {
> > +    margin-top: 0px;
> > +    margin-bottom: 0px;
> > +}
> 
> This hunk is unrelated and should go in a separate patch.

It *is* related, because without this the tables in this new page get
rendered which huge whitespace gaps, due to rst putting a <p> tag
inside each cell.

> For both this patch and the one with the CSS fix,
> 
>   Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux